How to modify Custom NBT Data on Items/Blocks?

ogfabio

I created a custom block like this:

info:

namespace: generators

items:

test_generator:

display_name: Test Generator

permission: test_generator

nbt: '{valueItem: true, isGenerator: true, generatorLevel: 1, generatorType: "MONEY"}'

resource:

generate: true

material: PAPER

textures:

- block/test_generator.png

specific_properties:

block:

placed_model:

type: REAL_NOTE

break_particles: ITEM

everything works fine ingame (block shows up and can be placed with no problems). As you can see i provided a custom NBT value for the block but when i try to modify the nbt values it just wont work…

This is my plugin code that uses tr7zw/Item-NBT-API to modify NBT values (works on non ItemsAdder stuff fine):

public static ItemStack buildGeneratorItem(GeneratorRegistry generator, int amount) throws NullPointerException {
        CustomStack customStack = CustomStack.getInstance("generators:" + generator.getItemAdderId());
        if (customStack == null)
            throw new NullPointerException("ItemsAdder stack for id " + generator.getItemAdderId() + " not found");

        ItemStack itemStack = new ItemBuilder(customStack.getItemStack())
                .setAmount(amount)
                .setName("§eMoney Generator §8[§7Lvl. " + generator.getLevel() + "§8]")
                .setLore(
                        "§7Place this generator on your plot to",
                        "§7start generating money.",
                        " ",
                        "§6§lINFORMATION",
                        "§6§l⋆ §7Generates§8: §e$" + Maths.formatNumberShort(generator.generateAmount*2) + "/min",
                        "§6§l⋆ §7Storage§8: §e$" + Maths.formatNumberShort(0),
                        "§b§l⋆ §7Shards§8: §b" + Maths.formatNumberShort(0),
                        " ",
                        "§8Right Click when placed"
                )
                .toItemStack();

        NBT.modify(itemStack, nbt -> {
            nbt.setBoolean("valueItem", true);
            nbt.setBoolean("isGenerator", false);
            nbt.setInteger("generatorLevel", generator.getLevel());
            nbt.setEnum("generatorType", generator.getGeneratorType());
        });

        return itemStack;
    }

As you can see im setting the isGenerator boolean to false but this just does not have a effect on the actual nbt value. The same happens when i try to add completely new nbt tags to a item that are not specified in the ItemsAdder block config.

Does anyone know what im doing wrong or is this just not possible?
Thanks for taking time in advance 🙂

LoneDev

Hello, no idea about what issue could be happening with that NBT lib, seems that it's not saving for some reason.
Can you try to use the same NBT.modify on a test item to see if it works?

ogfabio

LoneDev Hello thanks for your response. I mentioned in the post already that it works on non ItemsAdder stuff fine. I saw that your other plugin called LoneLibs uses the same library thats why i thought you might have a idea on why this is happening.

ogfabio

LoneDev

i tried to modify nbttags on the item like this and it does not work as well:

ItemMeta itemMeta = itemStack.getItemMeta();
        PersistentDataContainer persistentDataContainer = itemMeta.getPersistentDataContainer();

        persistentDataContainer.set(new NamespacedKey(plugin, "valueItem"),
                PersistentDataType.BOOLEAN, true);
        persistentDataContainer.set(new NamespacedKey(plugin, "isGenerator"),
                PersistentDataType.BOOLEAN, true);
        persistentDataContainer.set(new NamespacedKey(plugin, "generatorLevel"),
                PersistentDataType.INTEGER, generator.getLevel());
        persistentDataContainer.set(new NamespacedKey(plugin, "generatorType"),
                PersistentDataType.STRING, generator.getGeneratorType().name());
        persistentDataContainer.set(new NamespacedKey(plugin, "moneyStorage"),
                PersistentDataType.LONG, moneyStorage);
        persistentDataContainer.set(new NamespacedKey(plugin, "genShards"),
                PersistentDataType.INTEGER, genShards);

        itemStack.setItemMeta(itemMeta);

ogfabio

LoneDev

I also tried it this way using your NBT library (https://github.com/LoneDev6/FastNBT):

NItem nItem = new NItem(itemStack); NCompound compound = nItem.addCompound("generatorData"); compound.setBoolean("valueItem", true); compound.setBoolean("isGenerator", true); compound.setInt("generatorLevel", generator.getLevel()); compound.setString("generatorType", generator.getGeneratorType().name()); compound.setLong("moneyStorage", moneyStorage); compound.setInt("genShards", genShards); nItem.save();

itemStack = nItem.getItem(); return itemStack;

reading nbt (compound is always null):
NItem nItem = new NItem(itemStack); NCompound nCompound = nItem.getCompound("generatorData");

ogfabio

So i found a solution i need to use the CustomBlockPlace event when i want to check the nbt data. Otherwise the item will be air/null

LoneDev

Spigot does some strange stuff under the hood with ItemStacks, sometimes they are AIR but they contain data and the game freaks out.
Back then it was more reliable because AIR items were all null, so it was easier to differentiate deleted/invalid items.
The lib works fine as far as I know since I use it in ItemsAdder internally.
Please feel free to open a detailed issue report on the FastNBT lib Github page so that I can fix the issues if you ever find a way to reproduce the issue directly.
Might be also worth documenting the behaviour you experienced so that no one can feel confused about similar situations.

Thanks a lot for the patience, I'm working hard on a very big plugin update for my plugin CinematicsCore and it's taking a lot of my time.